Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on aind_ephys_utils #9

Open
alexpiet opened this issue Aug 26, 2024 · 0 comments
Open

Remove dependency on aind_ephys_utils #9

alexpiet opened this issue Aug 26, 2024 · 0 comments
Assignees

Comments

@alexpiet
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
This repository should contain basic analyses that are not dependent on ephys data. However the pyproject.toml includes a dependency on aind_ephys_utils. As far as I can tell, this is only used for aligning (

df = align.to_events(events, align_events, (tb, tf), return_df=True)
). However we have created generic alignment tools in https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-data-utils/blob/main/src/aind_dynamic_foraging_data_utils/alignment.py

Describe the solution you'd like
If the aind-ephys-utils contains alignment tools not in aind_dynamic_foraging_data_utils, they should be moved to the data_utils. If they alignment tools are redundant, we should use data_utils, to reduce the dependency

@hanhou hanhou assigned hanhou and ZhixiaoSu and unassigned hanhou Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@alexpiet @hanhou @ZhixiaoSu and others