Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using SI units #66

Open
Hjorthmedh opened this issue Nov 26, 2018 · 2 comments
Open

Using SI units #66

Hjorthmedh opened this issue Nov 26, 2018 · 2 comments

Comments

@Hjorthmedh
Copy link

Would it be possible to switch the SONATA format to SI units instead of natural units? I know a lot of simulators still use natural units, but there are so many potentials for mistakes.

@apdavison
Copy link
Contributor

I am not in favour of this.

My feeling is that using unprefixed SI units (note that what you're calling natural units are also SI units; we're not talking feet and inches!) will introduce more potential for mistakes, because (i) you end up doing more conversions and (ii) you introduce rounding errors due to floating point.

However, we do need to ensure that the units are specified explicitly as metadata, as close to the data as possible.

@hernando
Copy link
Collaborator

I agree with Andrew. Units should not be implicit, but the there should be metadata that specifies the units. In the simulation output part we have included units metadata in all datasets. However, I think we are missing it in the simulation config json.
Conversions may be unavoidable if different groups want to exchange data using different units though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants