Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing id in all nml files of examples/nml #108

Closed
asanin-epfl opened this issue Aug 19, 2019 · 2 comments
Closed

Missing id in all nml files of examples/nml #108

asanin-epfl opened this issue Aug 19, 2019 · 2 comments

Comments

@asanin-epfl
Copy link
Contributor

asanin-epfl commented Aug 19, 2019

Hi! All nml files in examples currently miss id attribute for tags: specificCapacitance and resistivity. When I manually add id, I'm able to transform them by BluePyOpt. Would it be ok to add those id here?

@pgleeson
Copy link
Contributor

Are you referring to the files in here: https://github.com/AllenInstitute/sonata/tree/master/examples/shared_components/biophysical_neuron_templates/nml?

There are multiple validity issues with those files and they shouldn't be considered as "NeuroML files" less so "NeuroML cell files". They're snippets of NeuroML used internally by Sonata readers to get combined with hoc/swc to make executable Neuron cell models. This is a rather adhoc pipeline (one long term solution is to allow full specification of the cell model in NeuroML and/or PyNN formats). Nevertheless, the changes you suggest could be made as long as they are tested with BMTK (and ideally NetPyNE, see for ex #74), to make sure they give the same results.

@asanin-epfl
Copy link
Contributor Author

Are you referring to the files in here: https://github.com/AllenInstitute/sonata/tree/master/examples/shared_components/biophysical_neuron_templates/nml?

Yes

Thank you for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants