Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isi violations show -1? #187

Open
rcpeene opened this issue Jan 16, 2024 · 3 comments
Open

isi violations show -1? #187

rcpeene opened this issue Jan 16, 2024 · 3 comments
Assignees

Comments

@rcpeene
Copy link

rcpeene commented Jan 16, 2024

Pamela has reported that some units show an isi violations value of -1 in the units table, and would like to know why. We guess its just a default value that didn't get filled in.

@jeromelecoq
Copy link
Collaborator

Carter to investigate to check when these happen and figure out the right value to be stored there.

@Ahad-Allen
Copy link
Collaborator

This is where the isi_viols are extracted from: https://github.com/AllenInstitute/ecephys_spike_sorting/blob/6210caab231fb18cb2902f6d0d456a749d903b58/ecephys_spike_sorting/modules/quality_metrics/metrics.py#L597. Carter and I found that it appears that these values are typically 0 when there is no violation rate, so we've reached out to Pamela to check the input data of a session where she is seeing -1s. The ones we checked had 0 -1 values

@jeromelecoq
Copy link
Collaborator

@Ahad-Allen to ping pamela on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants