Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to extract lava from a mekanism tank connected to pipez corrupts the game save #118

Open
GridCube opened this issue Aug 29, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@GridCube
Copy link

trying to extract lava from a mekanism tank using either a bucket or another mekanism tank causes the game to crash and then fail to launch from then on, the tank is connected to a create pulley by fluid Pipez

a few crash reports
crash-2023-08-28_21.36.00-server.txt
crash-2023-08-28_20.10.31-server.txt
crash-2023-08-28_20.14.18-server.txt
crash-2023-08-28_20.16.02-server.txt
crash-2023-08-28_21.29.21-server.txt
crash-2023-08-28_21.31.40-server.txt
2023-08-28_21 45 55

@Oscaz
Copy link

Oscaz commented Aug 29, 2023

Just encountered the same issue -- its caused by fluid being null in this function in
com.simibubi.create.content.fluids.transfer.FluidManipulationBehaviour

	protected void playEffect(Level world, BlockPos pos, Fluid fluid, boolean fillSound) {
+		if (fluid == null) return;
		BlockPos splooshPos = pos == null ? blockEntity.getBlockPos() : pos;
		FluidStack stack = new FluidStack(fluid, 1);

		SoundEvent soundevent = fillSound ? FluidHelper.getFillSound(stack) : FluidHelper.getEmptySound(stack);
		world.playSound(null, splooshPos, soundevent, SoundSource.BLOCKS, 0.3F, 1.0F);
		if (world instanceof ServerLevel)
			AllPackets.sendToNear(world, splooshPos, 10, new FluidSplashPacket(splooshPos, stack));
	}

I fixed it by adding a catch case and just leaving it at that -- there should probably be a more proper fix probably further up the chain, but this is working for me for now, so feel free to just use it for now. Obligatory take a backup, no warranty provided, my fix is provided as-is.

https://files.oscaz.dev/create-1.19.2-0.5.1.b.jar

As a general rule, don't download software from random strangers on the interwebs. If you can, clone the Create mod repo at commit 1c30b235 as I did, add the fix and recompile.

@GridCube
Copy link
Author

GridCube commented Sep 2, 2023

i tried to change the pipe for a laserio node and it crashed the game as well
crash-2023-09-02_13.18.47-server.txt

@oly2o6 oly2o6 added the bug Something isn't working label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants