From 2ce1139ee78be318cd4c7ff9096cd8d0fc8709e9 Mon Sep 17 00:00:00 2001 From: Sylvain Chapeland Date: Tue, 16 Jul 2024 09:33:04 +0200 Subject: [PATCH 1/2] added monitoring counter rdhCorruptedDropped --- README.md | 1 + doc/releaseNotes.md | 4 ++++ src/CommandLineUtilities/ProgramStatus.cxx | 1 + 3 files changed, 6 insertions(+) diff --git a/README.md b/README.md index be257ff3..807f33b2 100644 --- a/README.md +++ b/README.md @@ -667,6 +667,7 @@ metric format for the CRORC and the CRU is different, as different parameters ar | `"pktErrorCheck2"` | - | int | | `"pktErrorOversize"` | - | int | | `"orbitSor"` | - | int | +| `"rdhCorruptedDropped"` | - | int | | Tag key | Value | | --------------------- | --------------------- | diff --git a/doc/releaseNotes.md b/doc/releaseNotes.md index 9ced53b9..e2568af4 100644 --- a/doc/releaseNotes.md +++ b/doc/releaseNotes.md @@ -77,3 +77,7 @@ This file describes the main feature changes for released versions of ReadoutCar ## v0.45.2 - 29/05/2024 - Updated list of firmwares. - Added CRU option dropBadRdhEnabled. + +## next version +- Added some counters for roc-status: + - link (with --monitoring option only): rdhCorruptedDropped (for convenience - this value is extracted from the existing pktErrorCheck1 field, bits [23:16]). diff --git a/src/CommandLineUtilities/ProgramStatus.cxx b/src/CommandLineUtilities/ProgramStatus.cxx index bd6b7a20..885cdf60 100644 --- a/src/CommandLineUtilities/ProgramStatus.cxx +++ b/src/CommandLineUtilities/ProgramStatus.cxx @@ -443,6 +443,7 @@ class ProgramStatus : public Program .addValue((uint64_t)link.pktErrorCheck2, "pktErrorCheck2") .addValue((uint64_t)link.pktErrorOversize, "pktErrorOversize") .addValue((uint64_t)link.orbitSor, "orbitSor") + .addValue((uint8_t)((link.pktErrorCheck1 & 0x00ff0000 ) >> 16), "rdhCorruptedDropped") .addTag(tags::Key::SerialId, card.serialId.getSerial()) .addTag(tags::Key::Endpoint, card.serialId.getEndpoint()) .addTag(tags::Key::CRU, card.sequenceId) From 474a38c3c520bf8c9442d8870d8e875d77e12cea Mon Sep 17 00:00:00 2001 From: Sylvain Chapeland Date: Tue, 16 Jul 2024 09:33:39 +0200 Subject: [PATCH 2/2] v0.45.3 --- doc/releaseNotes.md | 2 +- src/ReadoutCardVersion.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/releaseNotes.md b/doc/releaseNotes.md index e2568af4..93f5cdb0 100644 --- a/doc/releaseNotes.md +++ b/doc/releaseNotes.md @@ -78,6 +78,6 @@ This file describes the main feature changes for released versions of ReadoutCar - Updated list of firmwares. - Added CRU option dropBadRdhEnabled. -## next version +## v0.45.3 - 16/07/2024 - Added some counters for roc-status: - link (with --monitoring option only): rdhCorruptedDropped (for convenience - this value is extracted from the existing pktErrorCheck1 field, bits [23:16]). diff --git a/src/ReadoutCardVersion.cxx b/src/ReadoutCardVersion.cxx index 6a572a83..296f7b1c 100644 --- a/src/ReadoutCardVersion.cxx +++ b/src/ReadoutCardVersion.cxx @@ -11,7 +11,7 @@ #include "ReadoutCard/Version.h" -#define O2_READOUTCARD_VERSION "0.45.2" +#define O2_READOUTCARD_VERSION "0.45.3" namespace o2 {