Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ZDC: Add configuration file PbPb, modify configuration file pp, add s…" #1702

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Revert "ZDC: Add configuration file PbPb, modify configuration file pp, add s…" #1702

merged 1 commit into from
Jul 15, 2024

Conversation

alcaliva
Copy link
Collaborator

Reverts #1659

@github-actions GitHub Actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@alcaliva alcaliva enabled auto-merge (squash) July 15, 2024 12:29
chiarazampolli
chiarazampolli previously approved these changes Jul 15, 2024
View reviewed changes
@alcaliva alcaliva added async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Jul 15, 2024
@alcaliva
Copy link
Collaborator Author

alcaliva commented Jul 15, 2024 •
edited
Loading

+async-2023-pbpb-apass4, async-2024-pp-cpass0, async-2024-pp-apass1

@github-actions github-actions bot dismissed chiarazampolli’s stale review July 15, 2024 12:35

Labels updated; please review again.

@chiarazampolli chiarazampolli disabled auto-merge July 15, 2024 12:46
@chiarazampolli chiarazampolli merged commit 5e962d7 into master Jul 15, 2024
10 of 11 checks passed
@chiarazampolli chiarazampolli deleted the revert-1659-zdc-new-config-pp-pb-reduced-bin branch July 15, 2024 12:46
@chiarazampolli
Copy link
Collaborator

Auto-merged disabled, since there is a check that fails (unrelated to this PR).
Merged by hand.

chiarazampolli pushed a commit that referenced this pull request Jul 15, 2024
@alcaliva @chiarazampolli
Revert "ZDC: Add configuration file PbPb, modify configuration file p…
b4ce1b7 
…p, add s…" (#1702)

This reverts commit 1af58ff.

(cherry picked from commit 5e962d7)
@chiarazampolli chiarazampolli removed async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiarazampolli chiarazampolli chiarazampolli approved these changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@martenole martenole Awaiting requested review from martenole

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaliva @chiarazampolli