Adopt settings of pbpb23 apass4 test3 + --thin-tracks in AOD #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
davidrohr,
martenole and
chiarazampolli
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| @@ -671,6 +678,10 @@ if [[ $PERIOD == "LHC22c" ]] || [[ $PERIOD == "LHC22d" ]] || [[ $PERIOD == "LHC2 | |||
| export ARGS_EXTRA_PROCESS_o2_aod_producer_workflow+=" --ctpreadout-create 1" | |||
| fi | |||
|
|
|||
| if [[ $ALIEN_JDL_LPMANCHORYEAR == "2023" ]] && [[ $BEAMTYPE == "PbPb" ]] ; then | |||
There was a problem hiding this comment.
Hello @shahor02 ,
Please remove this. Or even better change it to (so I don't open a PR myself):
if [[ $ALIEN_JDL_THINAODS == "1" ]] ; then
...
Thanks!
chiarazampolli
approved these changes
Jul 12, 2024
|
Thanks! For me it can be merged (@shahor02 , do you need to check further?) |
shahor02
added
async-2023-pbpb-apass4
chiarazampolli
removed
the
async-2023-pbpb-apass4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chiarazampolli Here I've added to the maser version of
setenv_extra.shthe TPC errors and extra flags for shared treatment as they were in apass4_test3. Note that they are always applied, not only for pbpb.Also enabled the AOD thinning (
--thin-tracks) but only for pbpb23. Please confirm that this is what we need.