Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To make it possible to run without the nodownload #1678

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

chiarazampolli
Copy link
Collaborator

@catalinristea , please, let me know in case something is missing. I thought this was done already, but I was wrong.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@catalinristea
Copy link
Collaborator

Hi Chiara,

It looks good to me.

In case you want to stay with "turl" field, this will do it,
sed -rn 's/.turl="([^"])".*/\1/p' wn.xml | awk -F "/" '{print $NF}' > list.list

Thanks,
Catalin.

@chiarazampolli
Copy link
Collaborator Author

chiarazampolli commented Jun 27, 2024

Hello @catalinristea ,

Your line does not work for me, what could work is this:

sed -rn 's/.*turl="([^"]*)".*/\1/p' $1 | awk -F "/" '{print $NF}'

(replace $1 with the filename that you need - also in your suggestion there should be $1 and now wn.xml)

Can you check? I have no preference, we can use any that works.
Chiara

@catalinristea
Copy link
Collaborator

Ciao Chiara,

Yes, it was the italics formatting of the web page which caught my asterisks. Sorry about it, your line is perfectly fine.
Thanks!

Yours, Catalin.

@chiarazampolli
Copy link
Collaborator Author

Ah ok!
Since in the end it does not change, let's merge this one as it is - I assume you don't have a strong preference.
Chiara

@chiarazampolli chiarazampolli merged commit d04d5c3 into AliceO2Group:master Jun 27, 2024
4 of 6 checks passed
@chiarazampolli
Copy link
Collaborator Author

Merging, failed tests are not related (e.g. missing token).

@alcaliva alcaliva added async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Aug 7, 2024
@alcaliva
Copy link
Collaborator

alcaliva commented Aug 7, 2024

Adding labels "async-2024-pp-apass1" and "async-2024-pp-cpass0" in order to apply the PR #1698

alcaliva pushed a commit that referenced this pull request Aug 7, 2024
@alcaliva alcaliva removed async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants