Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALICE 3: proc_id is actually a long #1675

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

ddobrigk
Copy link
Collaborator

...does not yet guarantee PYTHIA will accept it!

...does not yet guarantee PYTHIA will accept it!
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@ddobrigk
Copy link
Collaborator Author

@benedikt-voelkel @sawenzel, @jesgum just checked that this PR is definitely necessary (but not necessarily sufficient) for the seed usage in PYTHIA for MCGEN trains. Can you please merge?

The other issue is that PYTHIA seeds are max-limited to 900M, and job IDs can exceed that. Maybe this was dealt with already in the main simulation framework? If so, how?... Thanks!!!

@ddobrigk
Copy link
Collaborator Author

Hi again, sorry for the spam - maybe the vars set in setVarsFromALIEN_PROC_ID.sh are the better ones for the seed set? Perhaps the int16 version, for instance, of the ALIEN_PROC_ID? ...

@ddobrigk
Copy link
Collaborator Author

@jesgum I changed such that we only use bits 0-28 from the proc id. Can you please give this a try with your local setup? Many thanks! I'm reverting to draft until checked.

@ddobrigk ddobrigk marked this pull request as draft June 26, 2024 12:08
@ddobrigk ddobrigk marked this pull request as ready for review June 26, 2024 13:06
@ddobrigk
Copy link
Collaborator Author

@jesgum has tested this, and everything works flawlessly - and we should have perfect handling of seeds, as we'll be giving seeds to PYTHIA that go from 0 to 536870911 (which is allowed by PYTHIA). @sawenzel @benedikt-voelkel can we please merge if that's alright with you? Thank you very much!

@sawenzel sawenzel merged commit b737c27 into AliceO2Group:master Jun 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants