Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SimWF] Recompute number of workers used in TFs #1543

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

benedikt-voelkel
Copy link
Contributor

No description provided.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

@benedikt-voelkel
Copy link
Contributor Author

benedikt-voelkel commented Mar 21, 2024

@sawenzel note that at the moment, the argument that is passed with -j <workers> has no effect at this point.
Of course, what we can do is to simply take it if provided by the user and do not re-compute the number of workers in such cases.
However, that brings some complication that at the moment we set the number of workers usually in anchorMC.sh.
What we could do is to remove it there, so that always the default value of 8 can be taken for anchored (GRID) MCs.

Or we take the setting of the user when --pregenCollContext is not set. But as soon as --pregenCollContext is used, we do it as a function of IR like done here.

@benedikt-voelkel benedikt-voelkel force-pushed the dynamic-resources branch 2 times, most recently from ce7bc15 to 6e58ea7 Compare March 21, 2024 14:42
@benedikt-voelkel
Copy link
Contributor Author

Actually I just adapted the logic according to my precious comment: The re-computation of the number of workers is only done if --pregenCollContext is set. Otherwise, up to the user to choose

@benedikt-voelkel benedikt-voelkel force-pushed the dynamic-resources branch 3 times, most recently from 3a932b9 to 051cd2b Compare March 21, 2024 16:50
Only do so if --pregenCollContext is set, otherwise up to the user to
decide
@benedikt-voelkel benedikt-voelkel added async-2022-pp-apass4 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 mc labels Mar 22, 2024
@sawenzel sawenzel merged commit fb66dcc into AliceO2Group:master Mar 22, 2024
6 checks passed
@benedikt-voelkel benedikt-voelkel deleted the dynamic-resources branch March 25, 2024 07:27
@benedikt-voelkel benedikt-voelkel removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants