Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Anchor] Remove -k from QC run, return error code" #1515

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

benedikt-voelkel
Copy link
Contributor

Reverts #1513

I am sorry, I mixed up various different return codes from various places which led me to the conclusion that with the -k option it would return with 0 overall.
But it returns with 1 already.

Copy link

github-actions bot commented Mar 1, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

@benedikt-voelkel benedikt-voelkel merged commit 928d82f into master Mar 1, 2024
9 checks passed
@benedikt-voelkel benedikt-voelkel deleted the revert-1513-anchor branch March 1, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant