Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ITS/MFT light geom snapshots together with geometry-aligned #1501

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

shahor02
Copy link
Collaborator

Goes together with AliceO2Group/AliceO2#12761 : since MC creates its own snapshot of GeometryAligned, it should also create the lightweight ITS and MFT geometries. This is because now many workflows don't use GeometryAligned directly but fetch ITS(MFT)/Config/Geometry objects created from GeometryAligned.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

@shahor02 shahor02 removed the reco label Feb 26, 2024
@shahor02
Copy link
Collaborator Author

Hi, is the sim test supposed to be passed? I don't see how my PR can fail it.

@benedikt-voelkel
Copy link
Contributor

benedikt-voelkel commented Feb 28, 2024

Yes, it runs a test for anchored MC since you changed the steering script.

Since there is nothing explicitly in the logs and I see

##########################
# ERROR for anchored MCs #
##########################

it points to this issue: https://its.cern.ch/jira/browse/O2-4706

@shahor02
Copy link
Collaborator Author

Thanks @benedikt-voelkel !

@benedikt-voelkel
Copy link
Contributor

#1506 looks good @shahor02
I guess once you merge it, you could maybe steer the CI here again. Then we would have our first test of the pp anchored already here in the CI

@shahor02
Copy link
Collaborator Author

Merging after rebasing, CIs were green.

@shahor02 shahor02 merged commit 1483ae3 into AliceO2Group:master Apr 24, 2024
4 checks passed
@shahor02 shahor02 deleted the pr_nogeomCopy branch April 24, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants