Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporary workaround, to be reverted once O2 PR 12412 is in all async tags" #1465

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

davidrohr
Copy link
Collaborator

This reverts commit fd619fe.

@chiarazampolli : This is an old workaround I put in place for correct SHMSIZE and TIMEFRAME_RATE_LIMIT, since before O2 PR 12412 this was not used correctly.

I assume we are no longer running such old O2 tags, do we?
If not, I'd merge this to clean up the constants, since otherwise they are copy and pasted, and can get out of sync.
All is defined and used from workflow-multiplicities.sh now.

@chiarazampolli
Copy link
Collaborator

This needs AliceO2Group/AliceO2@f10cb50, which was ported to the branch stable-async on 8.12, so it is fine to merge it, since we don't process any data with older tags.

See:

https://github.com/AliceO2Group/AliceO2/commits/stable-async?after=194ecdddf57639c8544bc40b2c0f3edf8c6ec945+69
https://github.com/AliceO2Group/AliceO2/commits/async-20231208.1/

@davidrohr davidrohr merged commit dfc147c into AliceO2Group:master Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants