From 830be707dd8af79ef93d5a9b2ccabb12f096e312 Mon Sep 17 00:00:00 2001
From: Timo Wilken <timo.wilken@cern.ch>
Date: Tue, 20 Feb 2024 13:15:26 +0100
Subject: [PATCH] Fix Bash syntax issues found by shellcheck

Fix issues found in https://github.com/AliceO2Group/O2DPG/pull/1469, in
addition to those fixed in https://github.com/AliceO2Group/O2DPG/pull/1479.
---
 GRID/utils/extractErroredLogFiles.sh | 4 ++--
 GRID/utils/grid_submit.sh            | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/GRID/utils/extractErroredLogFiles.sh b/GRID/utils/extractErroredLogFiles.sh
index 81c21839d..20a0750ba 100755
--- a/GRID/utils/extractErroredLogFiles.sh
+++ b/GRID/utils/extractErroredLogFiles.sh
@@ -4,13 +4,13 @@
 # Beware that errors might occur outside of O2DPG tasks such as in preprocessing etc or not visible in logs
 
 mytar () {
-  tar $@
+  tar "$@"
 }
 if [[ $(uname) == "Darwin" ]]; then
     echo "Running on macOS. This needs gnu-tar"
     $(which gtar)
     mytar () {
-      gtar $@
+      gtar "$@"
     }
 fi
 
diff --git a/GRID/utils/grid_submit.sh b/GRID/utils/grid_submit.sh
index 7913f83ad..f364bed68 100755
--- a/GRID/utils/grid_submit.sh
+++ b/GRID/utils/grid_submit.sh
@@ -401,7 +401,7 @@ EOF
   spin[1]="|"
   spin[0]="\\"
   JOBSTATUS="I"
-  if [ "{WAITFORALIEN}" ]; then
+  if [ "${WAITFORALIEN}" ]; then
     echo -n "Waiting for jobs to return ... Last status : ${spin[0]} ${JOBSTATUS}"
   fi
   counter=0