Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StockFlow exports a Graph() function not extending Catlab's #113

Open
KevinDCarlson opened this issue Dec 18, 2023 · 2 comments
Open

StockFlow exports a Graph() function not extending Catlab's #113

KevinDCarlson opened this issue Dec 18, 2023 · 2 comments

Comments

@KevinDCarlson
Copy link
Contributor

The file src/visualization.jl imports Catlab.Graphics.Graphviz.Graph and then exports Graph, but this Graph does not extend Catlab.Graph so you get ambiguity complaints if you write using Catlab; using StockFlow; Graph. Some notebooks shouldn't/don't run because of this.
@KevinDCarlson
Copy link
Contributor Author

Relatedly, probably all these great example notebooks should be being run in CI. This breakage probably goes back to Catlab 0.15 starting to export Graph.

@Ong-Yi-Kai
Copy link

If anyone needs to run the notebooks, I solved this by replacing Graph(seirh) with StockFlow.Graph(seirh).

@Saityi Saityi mentioned this issue Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinDCarlson @Ong-Yi-Kai