-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperate default_dec_generate versions for 1d and 2d #147
Labels
Comments
GeorgeR227
changed the title
Seperate default_dec_generate versions for 1d and 2d.
Seperate default_dec_generate versions for 1d and 2d
Sep 7, 2023
Yes, we should also rethink whether the current method of passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since there exist DEC operators that depend on the dimension of the space they are applied on, such as the Lie Derivative and the Interior Product, we should organize these dimension specific implementations by letting the user choose separate default_dec_generate versions for 1d and 2d. Here's an example for 1d:
While we could do the same by passing a dimension parameter into the current default_dec_generate and then having the Lie Derivative and Interior Product implementations accept that dimension information, I feel this method organizes the operators a bit better for the user.
The text was updated successfully, but these errors were encountered: