Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming sources broken after v1.9.7 #1458

Open
lrobot opened this issue Nov 14, 2024 · 2 comments
Open

Incoming sources broken after v1.9.7 #1458

lrobot opened this issue Nov 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lrobot
Copy link

lrobot commented Nov 14, 2024

version: go2rtc version 1.8.4 linux/amd64

reproduce issue:
I create go2rtc.yaml

streams:
 browser_stream:
    - ""

and start ./go2rtc

producer stream("dst") : http://localhost:1984/webrtc.html?dst=browser_stream&media=camera+microphone
consumer stream("src"): http://localhost:1984/webrtc.html?src=browser_stream&media=video+audio

I can notice: http://localhost:1984/api/streams?src=browser_stream, produce work well.
but consumer can not hook to producer, error log is: "streams: unknown error"

18:30:57.042 TRC [webrtc] remote candidate="candidate:3152294625 1 udp 2122260223 172.22.85.187 57740 typ host generation 0 ufrag E3AA network-id 2"
18:30:57.042 TRC [streams] check cons=0 media=video, sendonly, VP8, VP9, H264, AV1
18:30:57.042 TRC [streams] skip cons=0 prod=0
18:30:57.042 TRC [streams] check cons=0 media=audio, sendonly, OPUS/48000/2, G722/8000, PCMU/8000, PCMA/8000, L16, PCML
18:30:57.042 TRC [streams] skip cons=0 prod=0
18:30:57.042 TRC [streams] skip stop none producer
18:30:57.042 DBG [webrtc] add consumer error="streams: unknown error"
18:30:57.042 TRC [api] ws msg type=webrtc/candidate
18:30:57.042 TRC [streams] skip stop none producer

I think may be this is because of below loop request check:

prod.url == info.GetSource()

if info, ok := cons.(core.Info); ok && prod.url == info.GetSource() {

I notice that the producer url is "" empty string. and the consumer source maybe also "" empty string. so that may is the cause of this issue.

@AlexxIT AlexxIT added the question Further information is requested label Nov 14, 2024
@AlexxIT AlexxIT self-assigned this Nov 14, 2024
@AlexxIT AlexxIT added bug Something isn't working and removed question Further information is requested labels Nov 14, 2024
@AlexxIT AlexxIT changed the title empty stream got incoming brower webrtc producer can not be consumer by other webpage Incoming sources broken after v1.9.7 Nov 14, 2024
@lrobot
Copy link
Author

lrobot commented Nov 14, 2024

sorry that, This may not a bug,
I found that: below config will cause issue

streams:
 browser_stream:
    - ""

and below config work well with: version: go2rtc version 1.8.4 linux/amd64
this may be the really "empty stream", the error config is a stream with "empty source url".
because of documentation not show how to config "empty stream". I create a issued config!!

streams:
 browser_stream:

@AlexxIT
Copy link
Owner

AlexxIT commented Nov 14, 2024

Incoming source also may have empty url. So it will be skipped. I needs to test this case.

@AlexxIT AlexxIT added this to the v1.9.8 milestone Nov 14, 2024
seydx pushed a commit to seydx/go2rtc that referenced this issue Nov 15, 2024
seydx pushed a commit to seydx/go2rtc that referenced this issue Nov 15, 2024
seydx pushed a commit to seydx/go2rtc that referenced this issue Nov 15, 2024
seydx pushed a commit to seydx/go2rtc that referenced this issue Nov 15, 2024
dagleaves pushed a commit to EscapeOracle/go2rtc that referenced this issue Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants