Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure ORA example instruction -- more concise #306

Closed
cansavvy opened this issue Oct 16, 2020 · 5 comments
Closed

Restructure ORA example instruction -- more concise #306

cansavvy opened this issue Oct 16, 2020 · 5 comments
Labels
before going live Needs to be done before we can "go live" or do testing

Comments

@cansavvy
Copy link
Contributor

Related to this discussion: #283 (comment)

The microarray ORA example needs some reorganization the instruction and steps used.

Specifically, we should make it a bit more terse and specific but also look out for where we can highlight other decisions/methods that could be used. Should these other methods/decisions be their own example -- either an rna-seq example or a part of a set of ORA? OR can we just highlight with comments and further instruction how to alter the ORA example to fit one's needs; ultimately getting across that the decisions we made are somewhat arbitrary and are not an implicit rule (Josh's words).

@cansavvy
Copy link
Contributor Author

Another more specific direction as a part of this issue is that some of the background information: see @jaclyn-taroni's comment here: https://github.com/AlexsLemonade/refinebio-examples/pull/283/files#r506455366 can be moved to the pathway analysis introduction file (#214).

Because this is the first pathway analysis module to be (re)added its conceivable that as we move along we will hammer out a strategy for this background information as well as what the "prescriptive but not a rule" instruction discussed here should look like.

@cansavvy
Copy link
Contributor Author

This and the intro paragraph determined in #349 can be addressed at the same time.

@cansavvy
Copy link
Contributor Author

An idea related to these changes from @envest: #356 (comment) Use a table. I think a lot of the info needs to be trimmed down here, but we can see if a table of sorts makes explanations more brief. (But we also might just be able to get rid of the explanations entirely and link out to somewhere that explains it well (a strategy we've used a lot when we are trying to be brief but still give info).

@cansavvy
Copy link
Contributor Author

Found a nice source for explaining hypergeometric tests in context of genes: https://dputhier.github.io/ASG/practicals/go_statistics_td/go_statistics_td_2015.html

@jaclyn-taroni jaclyn-taroni added the before going live Needs to be done before we can "go live" or do testing label Nov 23, 2020
@jaclyn-taroni
Copy link
Member

In my opinion, this was fully addressed by #377.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before going live Needs to be done before we can "go live" or do testing
Projects
None yet
Development

No branches or pull requests

2 participants