Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reliance on knitr:::parse_params() #6

Open
jashapiro opened this issue Jun 7, 2020 · 0 comments
Open

remove reliance on knitr:::parse_params() #6

jashapiro opened this issue Jun 7, 2020 · 0 comments

Comments

@jashapiro
Copy link
Member

While it is convenient and helpful to use knitr functions where possible to avoid new parsing errors, the use of unexported functions is not a good idea, as these could be changed in a future release.

knitr:::parse_params() is currently used to find whether a code block contains one of the flags that indicates a block should be replaced, but this could presumably be done by a more direct search for the flag options, without fully parsing the parameter list, and without relying on un exported external package code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant