avoid allocation if no transformation are necessary in setindex!

JuliaGeo · Jan 13, 2022 · 8d54130 · 8d54130
1 parent e3ea82e
commit 8d54130
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/cfvariable.jl b/src/cfvariable.jl
@@ -540,6 +540,12 @@ end
     return out
 end
 
+@inline function CFtransformdata(
+    data::AbstractArray{T,N},fv::Nothing,scale_factor::Nothing,
+    add_offset::Nothing,time_origin::Nothing,time_factor::Nothing,::Type{T}) where {T,N}
+    # no transformation necessary (avoid allocation)
+    return data
+end
 
 @inline _inv(x::Nothing) = nothing
 @inline _inv(x) = 1/x
@@ -568,6 +574,13 @@ end
     return out
 end
 
+@inline function CFinvtransformdata(
+    data::AbstractArray{T,N},fv::Nothing,scale_factor::Nothing,
+    add_offset::Nothing,time_origin::Nothing,time_factor::Nothing,::Type{T}) where {T,N}
+    # no transformation necessary (avoid allocation)
+    return data
+end
+
 # for scalar
 @inline function CFinvtransformdata(data,fv,scale_factor,add_offset,time_origin,time_factor,DT)
     inv_scale_factor = _inv(scale_factor)

diff --git a/test/test_scaling.jl b/test/test_scaling.jl
@@ -1,3 +1,6 @@
+using NCDatasets
+using Test
+
 filename = tempname()
 # The mode "c" stands for creating a new file (clobber)
 ds = NCDatasets.NCDataset(filename,"c")