Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when WoW returns "HEXENMEISTER" for class name #20

Open
croshy opened this issue Jul 12, 2021 · 6 comments
Open

Errors when WoW returns "HEXENMEISTER" for class name #20

croshy opened this issue Jul 12, 2021 · 6 comments
Labels
help wanted localization This is a bug caused by only supporting English.

Comments

@croshy
Copy link

croshy commented Jul 12, 2021

Using the burning crusade version

82x AutoGear\AutoGear.lua:1416: attempt to index field '?' (a nil value)
[string "@AutoGear\AutoGear.lua"]:1416: in function AutoGearSetStatWeights' [string "@AutoGear\AutoGear.lua"]:2255: in function AutoGearConsiderAllItems'
[string "@AutoGear\AutoGear.lua"]:1833: in function <AutoGear\AutoGear.lua:1610>

Locals:
class = "HEXENMEISTER"
spec = "Destruction"
(*temporary) = nil
(*temporary) = "HEXENMEISTER"
(*temporary) = "Destruction"
(*temporary) = 0
(*temporary) = "HEXENMEISTER"
(*temporary) = ""
(*temporary) = "Hexenmeister"
(*temporary) = "attempt to index field '?' (a nil value)"
weapons = nil

@AlexFolland
Copy link
Owner

How strange. Blizzard localized the class constants? "Destruction" is right, but "HEXENMEISTER" isn't. This will take some research.

That being said, the stat scanning only works in English anyway, so any fix for this is unlikely to allow the expected usage of the addon.

@AlexFolland AlexFolland added help wanted localization This is a bug caused by only supporting English. labels Jul 13, 2021
@AlexFolland AlexFolland changed the title Getting a lot of errors from auto gear Errors when WoW returns "HEXENMEISTER" for class name Jul 13, 2021
@croshy
Copy link
Author

croshy commented Jul 13, 2021

That is sad. Your ad on has so much potential to make things a lot easier for a blind player.

Do you expect the problems not to appear when I switched my client to English?

@AlexFolland
Copy link
Owner

I expect it'll work well with the game language set to English.

@croshy
Copy link
Author

croshy commented Jul 21, 2021

OK I tried that out with language said to English. But then our blind assistance add-ons we use won't work they are in German.

What would you need for a translation of your add-on? The guy that it's programming hour blind add-ons may have lists or other stuff for you you could get us assistance.
He made audio files of every singer item. Quest titles and all used words off the game 

@AlexFolland
Copy link
Owner

I think a huge refactor that involves changing language-specific WoW API calls like parts that scan the tooltip to language-agnostic calls like GetItemStats would be necessary. For the class list, I'm really not sure why the class constant is different ("HEXENMEISTER"), since I thought those were meant to be language-agnostic, but I guess they're not. More research would be needed for changing almost every part of the addon.

It's all possible, and I intend to do it some day, but it hasn't been a priority because both Synthetikaryote and I play the game in English. I do want to support this, but I don't have time in my life these days to do such an extensive overhaul, with a full-time job and a family.

@croshy
Copy link
Author

croshy commented Jul 24, 2021

 I can absolutely understand that. I'm a father myself and the word of Warcraft shall be fun not work.

I still think you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted localization This is a bug caused by only supporting English.
Projects
None yet
Development

No branches or pull requests

2 participants