From f2d8dbfc86fba87f89faddbd07e5b288c1cc1056 Mon Sep 17 00:00:00 2001 From: Bruno C Date: Wed, 24 Aug 2016 20:45:56 +0200 Subject: [PATCH] Minor changes --- .jshintrc | 4 +++- CONTRIBUTING.md | 4 ++++ index.js | 10 +++++----- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.jshintrc b/.jshintrc index c1f2978..dc6843c 100644 --- a/.jshintrc +++ b/.jshintrc @@ -1,3 +1,5 @@ { - "node": true + "node": true, + "undef": true, + "esnext": true } diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6599175..43b77d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,3 +11,7 @@ Either use a [EditorConfig](http://editorconfig.org/) plugin for your IDE - Use 4 spaces for indentation - Do not leave spaces on empty lines, or spaces at the end of lines - Ensure your files end with a new line + +## Pull Request + +- Please do not include version changes in your PR diff --git a/index.js b/index.js index 8b90502..6293277 100644 --- a/index.js +++ b/index.js @@ -156,7 +156,7 @@ display.header = function (str) { var getProjectName = function () { var deferred = Q.defer(); var parser = new xml2js.Parser(); - data = fs.readFile(settings.CONFIG_FILE, function (err, data) { + fs.readFile(settings.CONFIG_FILE, function (err, data) { if (err) { deferred.reject(err); } @@ -276,10 +276,10 @@ var atLeastOnePlatformFound = function () { display.success('platforms found: ' + _(activePlatforms).pluck('name').join(', ')); deferred.resolve(); } else { - display.error('No cordova platforms found.' + - 'Make sure you are in the root folder of your Cordova project' + - 'and add platforms with \'cordova platform add\''); - deferred.reject(); + display.error('No cordova platforms found. ' + + 'Make sure you are in the root folder of your Cordova project ' + + 'and add platforms with \'cordova platform add\''); + deferred.reject(); } }); return deferred.promise;