Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emojify icons not showing properly #837

Closed
vincentmegia opened this issue Sep 7, 2018 · 6 comments
Closed

emojify icons not showing properly #837

vincentmegia opened this issue Sep 7, 2018 · 6 comments
Labels
plugin Non-core related things question

Comments

@vincentmegia
Copy link

I'm using trumbowyg in my Angular6, i've encountered a problem where the emojify icons are not showing their images.
code:

declare var $:any;
declare var emojify:any;

ngOnInit(){
    $('#editor').trumbowyg({
        lang: 'hu',
        svgPath: '/assets/icons/icons.svg',
        removeformatPasted: true,
        autogrow: true,
        btns: [
            ['formatting'],
            ['undo', 'redo'], // Only supported in Blink browsers
            ['strong', 'em', 'del'],
            ['superscript', 'subscript'],
            ['link'],
            ['justifyLeft', 'justifyCenter', 'justifyRight', 'justifyFull'],
            ['unorderedList', 'orderedList'],
            ['horizontalRule'],
            ['removeformat'],
            ['foreColor', 'backColor'],
            ['emoji'],
            ['historyUndo','historyRedo'],
            ['noembed'],
            ['base64']
        ]
    });
    
    // Setup emojify.js
    emojify.setConfig({
        img_dir : '//cdnjs.cloudflare.com/ajax/libs/emojify.js/1.1.0/images/basic/',
        mode: 'img'
    });
    emojify.run();

image

@Alex-D Alex-D added the question label Sep 7, 2018
@Alex-D
Copy link
Owner

Alex-D commented Sep 7, 2018

Is there something in your console? Did you inspect the generated HTML?

@Alex-D Alex-D added the plugin Non-core related things label Sep 7, 2018
@zanechua
Copy link
Contributor

zanechua commented Sep 9, 2018

I am quite sure that his issue is related to this joypixels/emojify.js#175

I was having the same issue and had to use emojify.js another way hence my PR.

@sandrapender
Copy link

I'm seeing the same issue (Laravel + vue-trumbowyg), and it seems to also be affecting your emoji demo page: https://alex-d.github.io/Trumbowyg/demos/#plugins-emoji

image

Nothing in the console.

@zanechua
Copy link
Contributor

@sandrapender

The demo is not working because the loader hasn't been updated. It has been fixed in the latest version of develop which hasn't been merged with master.

What version of the emoji plugin and trumbowyg are you on?

You can view the newest demo at:

https://rawcdn.githack.com/Alex-D/Trumbowyg/v2.11.1/docs/demos/#plugins-emoji

@sandrapender
Copy link

Hey @zanechua I'm on Trumbowyg 2.11.1 and trumbowyg.emoji.js v0.1. It's working locally but not in staging/production. I'll wait for the fix to be merged. Thanks for taking the time to respond.

@Alex-D
Copy link
Owner

Alex-D commented Nov 28, 2018

Seems to be working now on demo page.

@Alex-D Alex-D closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Non-core related things question
Projects
None yet
Development

No branches or pull requests

4 participants