Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::path::absolute #332

Open
2 tasks
NyxCode opened this issue Jun 21, 2024 · 2 comments
Open
2 tasks

Use std::path::absolute #332

NyxCode opened this issue Jun 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@NyxCode
Copy link
Collaborator

NyxCode commented Jun 21, 2024

std::path::absolute got stabilized in 1.79.0

Is your feature request related to a problem? Please describe.
Nope!

Describe the solution you'd like
Use the stdlib's std::path::absolute

TODOs

  • figure out if we want to do that right away, or wait a bit until 1.79.0 is widely adopted
  • make sure our path::absolute does 1:1 the same thing
@NyxCode NyxCode added the enhancement New feature or request label Jun 21, 2024
@gustavo-shigueo
Copy link
Collaborator

They've stabilized it?! Awesome! This will help remove the duplicate we have in the cli branch. Though it is another technically a breaking change due to raising the MSRV

@gustavo-shigueo
Copy link
Collaborator

  • make sure our path::absolute does 1:1 the same thing

I'll create a PR applying the change to see if CI passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants