-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS/TS & React Example part has updated. #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the corrected version of your text: A reference has been fixed. Examples are updated based on the current repository and how the workers are handled. (The entire code has been revised in detail.) The Worker Provider component has been removed since it is no longer used in any of the examples. Wasm initialization has been made optional. (Currently, none of the examples are initializing Wasm separately from the SDK.) Configuration for handling files with a .aleo extension has been added. Support part for the .aleo extension for TypeScript users has been added.
Looks like I forgot to update the on-chain execution part. Will do it asap. |
ramidecodes
approved these changes
May 1, 2024
Zack-Xb
reviewed
May 10, 2024
In general great stuff, think this is a very valuable piece of documentation. |
ghostant-1017
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference has been fixed.
Examples are updated based on the current repository and how the workers are handled. (The entire code has been revised in detail.)
The Worker Provider component has been removed since it is no longer used in any of the examples.
Wasm initialization has been made optional. (Currently, none of the examples are initializing Wasm separately from the SDK.)
Configuration for handling files with a .aleo extension has been added. Support part for the .aleo extension for TypeScript users has been added.
UPDATE:
The Next.js example that I mentioned in the meeting is still pending as a PR in the SDK repo; however, it is more relevant to the create-aleo-app PR instead of this one. This update is aligned with the most popular React example.
You can check the status of the Next.js example PR here.