Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating an account don't email the password #11

Open
mawiseman opened this issue Aug 9, 2018 · 1 comment
Open

When creating an account don't email the password #11

mawiseman opened this issue Aug 9, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@mawiseman
Copy link

I think it would be better practice (and probably more secure) to send a link with userid and expiration date via jwt and force the user to choose their own password

https://jwt.io/

This would mean

  • admin passwords are floating around in emails
  • the user only had a limited time to action the email
@AlenPelin
Copy link
Owner

AlenPelin commented Sep 10, 2018

Thanks @mawiseman for valid point, which indeed makes sense to implement. It is however much more complex solution than current one, and therefore is way more risky to introduce even bigger vulnerability.

In fact, it will also require to replace password recovery mechanism on Sitecore login page because SignUpRules relies on it.

@AlenPelin AlenPelin added the enhancement New feature or request label Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants