Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this auto rebase-able on brix/crypto-js #3

Open
paviad opened this issue Jan 21, 2023 · 0 comments
Open

Make this auto rebase-able on brix/crypto-js #3

paviad opened this issue Jan 21, 2023 · 0 comments

Comments

@paviad
Copy link

paviad commented Jan 21, 2023

One of the big arguments against adopting this library is that it has "less eyes" on it

I see that you have invested a lot of work into converting the original library to ES6 however it is not trivial to "rebase" this fork on changes upstream.

My suggestion is to split the conversion process into two distinct steps that will enable easier rebasing:

  1. Move all code that does not change from inside the existing source files to other files, agnostic of the module system.
  2. Complete the migration to ES6 based on that.

Does that sound feasible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant