Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Collect and present all errors at once #4814

Open
sebastian opened this issue Nov 6, 2020 · 1 comment
Open

Collect and present all errors at once #4814

sebastian opened this issue Nov 6, 2020 · 1 comment

Comments

@sebastian
Copy link
Member

We have the evil habit of presenting a single error at a time.
Given the complexity and share number of our restrictions it's not uncommon that you run into multiple restrictions at a time.
Our system fails early and fast and only show you the first problem it has encountered. Once the problem has been fixed we then show whatever else ails the query.

I think it would be more compassionate to the analyst to list all the problems we know exist at once. That way they have a better sense of what needs fixing, and save themselves some superfluous debug cycles (which undoubtedly erodes they joy and Christmas spirit a little bit each time).

@cristianberneanu
Copy link
Member

I am not a fan of this idea. The root of the problem is that we have too many restrictions, making it hard to generate valid queries. We should work on that, even though that is the far harder problem.

Showing multiple errors at the same time could be more confusing, as the first error might be the cause of the others.
Continuing to validate the query will lead to more crashes, as the current validations assume previous validations passed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants