Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner: merge stats objects and logPerfEvent #43

Open
mhofman opened this issue Dec 7, 2021 · 0 comments
Open

Runner: merge stats objects and logPerfEvent #43

mhofman opened this issue Dec 7, 2021 · 0 comments
Assignees

Comments

@mhofman
Copy link
Member

mhofman commented Dec 7, 2021

Originally the runner took the approach of logging JSON perf events to a file, representing various events, and capturing CPU and memory usage at regular intervals.

In order to generate stat summaries and more structured data, #36 is introducing stats objects, which are saved wholesale at the end of a run.

We should merge the approaches so that:

  • perf events are still generated, but from the stats structure instead of explicit calls
  • perf events could be used to "stream" noteworthy events, raw block/cycle data, as well as intermediate summaries (e.g. per stage)
  • CPU and memory usage would be integrated with other stats (see Include CPU and memory usage stats summary #42)
  • it may no longer be necessary to dump a large "stats" event at the end containing all raw and summarized data

Since summaries as a single object is useful for jq processing, maybe there should be a way to regenerate the summarized stats object easily from the raw event stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants