Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(z:acceptance): fix flakey z:acceptance/vaults.test.js #10643

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(z:acceptance): fix flakey z:acceptance/vaults.test.js #10643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions a3p-integration/proposals/z:acceptance/vaults.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,7 @@ test.serial('user cannot open a vault above debt limit', async t => {
);
});

// TODO #10599. marked as `skip` since several flakes were observed
test.skip('user can open a vault under debt limit', async t => {
test.serial('user can open a vault under debt limit', async t => {
const istBalanceBefore = await getISTBalance(GOV1ADDR);
const activeVaultsBefore = await listVaults(GOV1ADDR, walletUtils);

Expand All @@ -241,11 +240,12 @@ test.skip('user can open a vault under debt limit', async t => {
const istBalanceAfter = await getISTBalance(GOV1ADDR);
const activeVaultsAfter = await listVaults(GOV1ADDR, walletUtils);

t.is(
istBalanceBefore + Number(mint),
istBalanceAfter,
'The IST balance should increase by the minted amount',
await tryISTBalances(
t,
scale6(istBalanceAfter),
scale6(istBalanceBefore + Number(mint)),
);

t.is(
activeVaultsAfter.length,
activeVaultsBefore.length + 1,
Expand Down
Loading