Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fast-usdc): count computrons for advancement #10621

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

samsiegart
Copy link
Contributor

closes #10511

Testing

~/agoric-sdk/packages/boot$ SWINGSET_WORKER_TYPE=xsnap yarn test test/fast-usdc/

...

  ✔ makes usdc advance (5.5s)
    ℹ fusdc advance computrons (3 oracles) 46517841n

@samsiegart samsiegart requested a review from a team as a code owner December 4, 2024 21:00
Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39d3796
Status: ✅  Deploy successful!
Preview URL: https://8fdfddb1.agoric-sdk.pages.dev
Branch Preview URL: https://srs-measure-fu.agoric-sdk.pages.dev

View logs

@dckc
Copy link
Member

dckc commented Dec 4, 2024

ℹ fusdc advance computrons (3 oracles) 46517841n

46.5Mc is over 1/2 of the current 65Mc block budget. So no more than 1 per block, and that's if all the oracles report in 1 block.

My prototype measurement was 28.8Mc, but that was using a single oracle and who knows what other short-cuts.

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want a measurement in every ci run, this doesn't seem to get us there yet

const test: TestFn<WalletFactoryTestContext> = anyTest;
const {
SLOGFILE: slogFile,
SWINGSET_WORKER_TYPE: defaultManagerType = 'local',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this to get set to xsnap somewhere in ci, but I don't see it.

I'm not certain where the bar should be. hm.

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

based on discussion with @turadg , on-demand measurements suffice.

@samsiegart samsiegart added the automerge:rebase Automatically rebase updates, then merge label Dec 4, 2024
@mergify mergify bot merged commit 8b9c8db into master Dec 4, 2024
81 checks passed
@mergify mergify bot deleted the srs-measure-fu branch December 4, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf measurement and profiling of FU w/SwingSet
2 participants