Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in integration test coverage for NPM packages #9258

Open
mhofman opened this issue Apr 19, 2024 · 0 comments
Open

Regression in integration test coverage for NPM packages #9258

mhofman opened this issue Apr 19, 2024 · 0 comments
Labels
bug Something isn't working devex developer experience technical-debt

Comments

@mhofman
Copy link
Member

mhofman commented Apr 19, 2024

Describe the bug

#8829 updated the getting-started test to actually follow the getting started steps from our documentation. However when doing so, it dropped the step where the dapp is updated to use the just created NPM packages from the agoric-sdk repo. This is a side effect of dapp instructions no longer using agoric-cli to install deps.

Now we are effectively no longer testing that released NPM packages are compatible with dapps if they were to upgrade to these packages. While the current agoric install $npm_tag is undocumented (see Agoric/documentation#904 (comment)) and has limitations (it relies on yarn internally, see #9209), it's still usable to force update deps in dapps.

This is however half the problem, as the dapp uses an a3p based chain, which is by definition older than the agoric-sdk under test, and publishing a contract build from a newer SDK to an older chain is not supported. To make this work correctly, we'd need to use an a3p image built from an upgraded chain, like the one produced by the layers of a3p-integration. As such, this is likely a test that need to run on top of the docker-build test now.

Link-cli would need extra work to get working as it'd need to link against the SDK inside the a3p image (which would not translate well to outside the docker image links, unless we got smart on mount points). We should consider dropping altogether since it's not a flow intended for public usages anymore.

To Reproduce

Steps to reproduce the behavior:

  1. Run getting-started integration test. E.g. locally with:
    scripts/registry.sh bg-publish registry/yarn
    scripts/registry.sh test registry/yarn main
    

Expected behavior

dapp in integration test using agoric packages built from the agoric-sdk source

Platform Environment

  • CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devex developer experience technical-debt
Projects
None yet
Development

No branches or pull requests

2 participants