Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Interchain stack versions for agoric-sdk #9172

Open
Tracked by #8225 ...
JimLarson opened this issue Mar 30, 2024 · 2 comments
Open
Tracked by #8225 ...

Upgrade Interchain stack versions for agoric-sdk #9172

JimLarson opened this issue Mar 30, 2024 · 2 comments
Assignees
Labels
agoric-cosmos enhancement New feature or request

Comments

@JimLarson
Copy link
Contributor

JimLarson commented Mar 30, 2024

What is the Problem Being Solved?

This tracks the agoric-sdk work for #8225.

See also #9180 for considerations specific to the upgrade handler.

Description of the Design

See https://github.com/Agoric/agoric-sdk/wiki/Upgrading-the-Interchain-Stack

See Protobuf section of cosmos-sdk Upgrade Guide.

In IBC-go 6-to-7 migration:

  • See tendermint registration instructions for app.go.

Must also review the ibc-go changelog.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@JimLarson JimLarson added enhancement New feature or request agoric-cosmos labels Mar 30, 2024
@JimLarson JimLarson self-assigned this Mar 30, 2024
@JimLarson
Copy link
Contributor Author

Note from the upgrading guide:

If you are using a app.go without dependency injection, add the following lines to your app.go in order to provide newer gRPC services:

autocliv1.RegisterQueryServer(app.GRPCQueryRouter(), runtimeservices.NewAutoCLIQueryService(app.ModuleManager.Modules))

reflectionSvc, err := runtimeservices.NewReflectionService()
if err != nil {
    panic(err)
}
reflectionv1.RegisterReflectionServiceServer(app.GRPCQueryRouter(), reflectionSvc)

@JimLarson
Copy link
Contributor Author

Further note from the upgrade guide:

EventTypeMessage events, with sdk.AttributeKeyModule and sdk.AttributeKeySender are now emitted directly at message exececution (in baseapp). This means that the following boilerplate should be removed from all your custom modules:

ctx.EventManager().EmitEvent(
	sdk.NewEvent(
		sdk.EventTypeMessage,
		sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
		sdk.NewAttribute(sdk.AttributeKeySender, `signer/sender`),
	),
)

The module name is assumed by baseapp to be the second element of the message route: "cosmos.bank.v1beta1.MsgSend" -> "bank". In case a module does not follow the standard message path, (e.g. IBC), it is advised to keep emitting the module name event. Baseapp only emits that event if the module has not already done so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants