Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify trigger in contextualized slog sender #10797

Open
mhofman opened this issue Jan 4, 2025 · 0 comments · May be fixed by #10855
Open

Classify trigger in contextualized slog sender #10797

mhofman opened this issue Jan 4, 2025 · 0 comments · May be fixed by #10855
Assignees
Labels
enhancement New feature or request telemetry

Comments

@mhofman
Copy link
Member

mhofman commented Jan 4, 2025

What is the Problem Being Solved?

The contextualized slog sender generates a high level trigger type based on the source of the inbound trigger (timer poll, bridge inbound, kernel update event, etc.)

For bridge inbound triggers we could benefit from further classifying the type of action, and recording that on the trigger context for later querying. @warner wrote a pretty good classifier in python, and it should be pretty easy to port that to the contextual slog sender.

Description of the Design

Port the classify-runs logic to classify the run, and add a run.trigger.classification field to the triggerContext.

Since we now include body of the bridge action, or other source type info in the inbound slog event, there should no longer be a need to wait for the first delivery in the run to classify the run itself.

Security Considerations

None

Scaling Considerations

None, telemetry only. It would simplify queries we make in the future against classified runs.

Test Plan

Manual on mainnet slog activity

Upgrade Considerations

Slog sender are part of the chain software upgrade but we can technically use new or updated ones dynamically through config.

@mhofman mhofman added the enhancement New feature or request label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request telemetry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants