fail the prepare step if the Software Upgrade proposal doesn't get voted in

[turadg]

The run_prepare.sh failed but didn't halt the build:
Agoric/agoric-sdk#9204 (comment)

It wasn't discovered until the run_execute.sh:

#25 [use-upgrade-next execute-upgrade-next 7/7] RUN ./run_execute.sh UNRELEASED_UPGRADE
#25 0.179 
#25 0.179  _______ _     _ _______ _______ _     _ _______ _______
#25 0.179  |______  \___/  |______ |       |     |    |    |______
#25 0.179  |______ _/   \_ |______ |_____  |_____|    |    |______
#25 0.179 
#25 0.179  _     _  _____   ______  ______ _______ ______  _______
#25 0.179  |     | |_____] |  ____ |_____/ |_____| |     \ |______
#25 0.179  |_____| |       |_____| |    \_ |     | |_____/ |______
#25 0.179 
#25 0.179 Execute the upgrade in consensus
#25 0.179 ENV_SETUP starting
#25 0.427 ENV_SETUP finished
#25 0.455 FAIL: Upgrade plan name agoric-upgrade-14 does not match the expected value UNRELEASED_UPGRADE
#25 ERROR: process "/bin/bash -c ./run_execute.sh UNRELEASED_UPGRADE" did not complete successfully: exit code: 1

[mhofman]

I thought by now all .sh scripts had fail on error? Maybe agd CLI doesn't error in this case, which would be surprising.

[turadg]

Seems it isn't.

agoric-3-proposals/packages/synthetic-chain/public/upgrade-test-scripts/run_prepare.sh

Line 4 in 2e9d4c1

set -eo pipefail

The execution got down to agd tx which failed and the script didn't.

[mhofman]

I think some commands "succeed" but return a code != 0, which really is counter productive IMO