Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Quickstart overly complicated #1549

Open
tadaspetra opened this issue May 28, 2024 · 1 comment
Open

Flutter Quickstart overly complicated #1549

tadaspetra opened this issue May 28, 2024 · 1 comment

Comments

@tadaspetra
Copy link

A general comment about the Flutter quickstart is that it is overly complicated for being a "quick start". The messageCallback and eventCallback seem to be an opinionated messaging system built along with the quickstart. This seems to be an extra feature, that is unnecessary to start.

Not only that, those functions are not covered anywhere on this page. So, if a user copies all the code into their project, they will have errors.

Removing this messaging system would remove about 75% of the code in this snippet, making it much more readable. Any gaps left by this can be filled in with a paragraph above.

Screenshot 2024-05-28 at 2 10 11 PM

There are other examples of unnecessary code throughout the document. For example int localUid = -1 is declared, but never used. Same thing with isBroadcaster.

@atovpeko
Copy link
Contributor

atovpeko commented Nov 1, 2024

@tadaspetra I can't find this page in the current docs. Can you please check if there is still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants