Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mypy and Coverage.py #14

Closed
areibman opened this issue Sep 3, 2023 · 2 comments
Closed

Add Mypy and Coverage.py #14

areibman opened this issue Sep 3, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@areibman
Copy link
Contributor

areibman commented Sep 3, 2023

🚀 Feature Request

💡 Got a brilliant idea?
Currently, our test coverage is not being tracked. Also, we want to abide by Mypy typing

🤔 Is your feature request related to a problem?
We don't have adequate coverage reporting.

🎉 Describe the solution you'd like
Add mypy and coverage.py to our tox file.
@areibman areibman added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 3, 2023
@the-praxs the-praxs mentioned this issue Apr 17, 2024
Merged
@the-praxs
Copy link
Member

Working on this in this PR #153

@siyangqiu
Copy link
Contributor

Merged. Thanks @the-praxs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siyangqiu @areibman @the-praxs