Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with debouncing #22

Open
ViggoAvatar opened this issue Mar 31, 2022 · 9 comments
Open

Issue with debouncing #22

ViggoAvatar opened this issue Mar 31, 2022 · 9 comments

Comments

@ViggoAvatar
Copy link

There seems to be some kind of issue with the code not properly running with the current debouncing method. in order to get the heater to heat i need to hold both buttons while it's heating, letting go will instantly cancel the process and the animation will stop where it left off, been snooping around in the code for a bit but first I'm checking whether or not i made a mistake with the hardware.

@toto99303
Copy link

There seems to be some kind of issue with the code not properly running with the current debouncing method. in order to get the heater to heat i need to hold both buttons while it's heating, letting go will instantly cancel the process and the animation will stop where it left off, been snooping around in the code for a bit but first I'm checking whether or not i made a mistake with the hardware.

It's not only you. I have exaclty the same issue and I thought my board has problems. Then I recreated the whole thing on a breadboard using brand new Arduino Pro Mini 3.3V 8Mhz and it's behaving exactly the same. There's definetely a problem with the code.

@ViggoAvatar
Copy link
Author

ViggoAvatar commented Apr 17, 2022

There seems to be some kind of issue with the code not properly running with the current debouncing method. in order to get the heater to heat i need to hold both buttons while it's heating, letting go will instantly cancel the process and the animation will stop where it left off, been snooping around in the code for a bit but first I'm checking whether or not i made a mistake with the hardware.

It's not only you. I have exaclty the same issue and I thought my board has problems. Then I recreated the whole thing on a breadboard using brand new Arduino Pro Mini 3.3V 8Mhz and it's behaving exactly the same. There's definetely a problem with the code.

Good to see im not the only one with the problem, I have a quick fix, I'll make a fork for it. It still has problems properly dealing with double press.

edit:
https://github.com/ViggoAvatar/Solder-Reflow-Plate
there you go

@toto99303
Copy link

Thanks! Did you also had issues changing temperature with Up/Down buttons?
I'll try your version now.

@toto99303
Copy link

Works great, thank you very much @ViggoAvatar !

@vonryan123
Copy link

4809 Version tested working!
https://github.com/vonryan123/Solder-Reflow-Plate

@deafloo
Copy link

deafloo commented May 3, 2022

@vonryan123 would you mind creating a pull request for your 4809 software?

@vonryan123
Copy link

@vonryan123 would you mind creating a pull request for your 4809 software?

I don't really know much about code nor pretend to, if I understood what a pull request was or why its needed I would.

@deafloo
Copy link

deafloo commented May 3, 2022

well done! With this pull request, the maintainer can copy your code in his empty directory and it is much easier to find for others

@JoeLutz11
Copy link

Turning the switches by 180° solved the Problem for me, the little notch on the buttons has to be on the left side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants