meson.build fails to respect pkg-config xkbcommon --cflags

[jengelh]

If xkbcommon.pc specifies a different include dir, a build failure can ensue in kmscon because one target seems to ignore the Cflags from xkbcommon.pc.

[    6s] [16/85] cc -Isrc/mod-bbulk.so.p -Isrc -I../src -Iexternal -I../external -I/usr/include/libxkbcommon -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -ffast-math -fno-strict-aliasing -ffunction-sections -fdata-sections -fstack-protector -fvisibility=hidden -D_GNU_SOURCE -D_POSIX_C_SOURCE=200809L -include /home/abuild/rpmbuild/BUILD/kmscon-9.0.0/x86_64-suse-linux/config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -fPIC -MD -MQ src/mod-bbulk.so.p/kmscon_mod_bbulk.c.o -MF src/mod-bbulk.so.p/kmscon_mod_bbulk.c.o.d -o src/mod-bbulk.so.p/kmscon_mod_bbulk.c.o -c ../src/kmscon_mod_bbulk.c
[    6s] [17/85] /usr/bin/python3 /home/abuild/rpmbuild/BUILD/kmscon-9.0.0/tools/embedded_file.py --regex '^/\*.*$' '' --regex '^ \*.*$' '' --regex '^[ \t]*' '' --regex '[\r\n]' '' ../src/text_gltex_atlas.vert src/mod-gltex.so.p
[    6s] [18/85] cc -Isrc/libconf.a.p -Isrc -I../src -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -ffast-math -fno-strict-aliasing -ffunction-sections -fdata-sections -fstack-protector -fvisibility=hidden -D_GNU_SOURCE -D_POSIX_C_SOURCE=200809L -include /home/abuild/rpmbuild/BUILD/kmscon-9.0.0/x86_64-suse-linux/config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -fPIC -MD -MQ src/libconf.a.p/conf.c.o -MF src/libconf.a.p/conf.c.o.d -o src/libconf.a.p/conf.c.o -c ../src/conf.c
[    6s] FAILED: src/libconf.a.p/conf.c.o 
[    6s] cc -Isrc/libconf.a.p -Isrc -I../src -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -ffast-math -fno-strict-aliasing -ffunction-sections -fdata-sections -fstack-protector -fvisibility=hidden -D_GNU_SOURCE -D_POSIX_C_SOURCE=200809L -include /home/abuild/rpmbuild/BUILD/kmscon-9.0.0/x86_64-suse-linux/config.h -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -fPIC -MD -MQ src/libconf.a.p/conf.c.o -MF src/libconf.a.p/conf.c.o.d -o src/libconf.a.p/conf.c.o -c ../src/conf.c
[    6s] ../src/conf.c:40:10: fatal error: xkbcommon/xkbcommon.h: No such file or directory
[    6s]    40 | #include <xkbcommon/xkbcommon.h>

[eli-schwartz]

kmscon/src/meson.build

Line 236 in 20a2fc4

conf = static_library('conf', 'conf.c')

This doesn't link to the xkbcommon dependency, but it should.

The fix should be trivial.