From 7540eb8b6e22f7e634045fa82f0b53c0da0c6dac Mon Sep 17 00:00:00 2001 From: simplyphp Date: Tue, 2 Aug 2016 20:11:52 -0500 Subject: [PATCH 1/3] Resolved issue #110, fixed64 is used in all other files for pokemon_id --- .../Requests/Messages/SetFavoritePokemonMessage.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto b/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto index 0621c6aeb..92f0d20b5 100644 --- a/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto +++ b/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto @@ -2,6 +2,6 @@ syntax = "proto3"; package POGOProtos.Networking.Requests.Messages; message SetFavoritePokemonMessage { - uint64 pokemon_id = 1; // needs to be uint64, tested by Grover + fixed64 pokemon_id = 1; // uint64 does not work; see issue #110; verified that all other places use fixed64 for pokemon_id bool is_favorite = 2; } From a3cbcd84127c26c1c6d7cc00fe34f47e3c7a417c Mon Sep 17 00:00:00 2001 From: simplyphp Date: Wed, 3 Aug 2016 08:40:08 -0500 Subject: [PATCH 2/3] Resolved to int64 --- .../Requests/Messages/SetFavoritePokemonMessage.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto b/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto index 92f0d20b5..3c1cbc7c6 100644 --- a/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto +++ b/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto @@ -2,6 +2,6 @@ syntax = "proto3"; package POGOProtos.Networking.Requests.Messages; message SetFavoritePokemonMessage { - fixed64 pokemon_id = 1; // uint64 does not work; see issue #110; verified that all other places use fixed64 for pokemon_id + int64 pokemon_id = 1; bool is_favorite = 2; } From 631d23ddae5c38d37fe682748565a5be0cd11ff4 Mon Sep 17 00:00:00 2001 From: simplyphp Date: Wed, 3 Aug 2016 08:43:48 -0500 Subject: [PATCH 3/3] Resolved to int64 --- .../Requests/Messages/SetFavoritePokemonMessage.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto b/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto index 3c1cbc7c6..64b52b3d3 100644 --- a/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto +++ b/src/POGOProtos/Networking/Requests/Messages/SetFavoritePokemonMessage.proto @@ -2,6 +2,6 @@ syntax = "proto3"; package POGOProtos.Networking.Requests.Messages; message SetFavoritePokemonMessage { - int64 pokemon_id = 1; + int64 pokemon_id = 1; // Do not change https://github.com/AeonLucid/POGOProtos/pull/126 bool is_favorite = 2; }