Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Diff viewer not working correctly #19

Open
abhinav1311 opened this issue Apr 18, 2023 · 1 comment
Open

JSON Diff viewer not working correctly #19

abhinav1311 opened this issue Apr 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@abhinav1311
Copy link

if any of the json file is not correct and fails in parsing then its not working and throwing error.
for example if we remove comma from old json and check it will give parse error.

Difference viewer should show all the differences not just parsed json

@Aeolun
Copy link
Owner

Aeolun commented Jun 19, 2023

If you are diffing JSON (really JS objects) the JSON has to be valid. If you are diffing text then it shouldn't matter (but it's probably hard to convert invalid JSON to text).

Can you provide examples of the failing files/code?

@Aeolun Aeolun added the bug Something isn't working label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants