Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-7946] - Removed option to store payment state using store api (headless) - subscribed event has been removed. #340

Open
AndreasA opened this issue Jan 17, 2023 · 5 comments
Assignees
Labels
Breaking change Indicates a change that has caused a major version update Bug report Indicates that issue has been marked as a possible bug

Comments

@AndreasA
Copy link
Contributor

AndreasA commented Jan 17, 2023

Describe the bug
Before the merge of PW-7218 the context switch event was used to store adyen payment state data upon selecting the payment method.

Since the merge of PW-7218 this seems to have been removed.

I guess the intention was to move that logic from the PaymentSubscriber to the ContextSubscriber.

Versions
Shopware version: 6.4.18.0
Plugin version: develop / 5f58d08

To Reproduce
See description.

@candemiralp candemiralp changed the title PW-7218 - Removed option to store payment state using store api (headless) - subscribed event has been removed. [PW-7946] - Removed option to store payment state using store api (headless) - subscribed event has been removed. Jan 23, 2023
@candemiralp candemiralp self-assigned this Jan 23, 2023
@candemiralp
Copy link
Member

Hello @AndreasA,

Thank you for raising this issue. We created an internal investigation ticket to revisit the logic in that part of the plugin.

Best Regards,
Can

@candemiralp
Copy link
Member

Hello @AndreasA,

I would like to inform you about that we are still investigating how we can re-support that functionality. Indeed, it is a breaking change for the headless integrations, which shouldn't be the case in a feature version upgrade. I will inform you again after finding a non-breaking implementation for this issue.

During this time period, could you please share your use-case? As a follow-up question, are you sending the fresh stateData obtained from the component/drop-in to the Shopware 6 backend?

Best Regards,
Can

@candemiralp candemiralp added Bug report Indicates that issue has been marked as a possible bug Breaking change Indicates a change that has caused a major version update labels Feb 9, 2023
@AndreasA
Copy link
Contributor Author

AndreasA commented Feb 9, 2023

@candemiralp Currently the plugin is set to the last version before this change, I just noticed that with the next update there will be an issue. The stateData would usually be set upon payment method change on a separate PWA that only uses the store-api and has not direct Shopware 6 frontend (headless).

@AndreasA
Copy link
Contributor Author

Hi @candemiralp has this been fixed with the recent 6.5 support being added to the plugin or is it still open?

if it is still open, when will it be fixed?

@AndreasA
Copy link
Contributor Author

@candemiralp Do I understand this correctly and the payment state data from e.g. card component is now sent as a parameter upon calling the handle-payment method? If so, I guess I could just remember the data in memory or session storage and include it upon calling the handle-payment method now instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Indicates a change that has caused a major version update Bug report Indicates that issue has been marked as a possible bug
Projects
None yet
Development

No branches or pull requests

2 participants