-Xshareclasses option added to JAVA_TOOL_OPTIONS #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathappali
changed the title
|
Any update on this work item? Thank you |
|
@bharathappali - there's a merge conflict... |
bharathappali
force-pushed
the
fix-env-scc
branch
2 times, most recently
from
5bce181
to
3e3001a
Compare
bharathappali
changed the title
|
@karianna I have resolved the merge conflicts. Can I please have your review? |
karianna
approved these changes
Dec 4, 2020
Signed-off-by: bharathappali <[email protected]>
bharathappali
force-pushed
the
fix-env-scc
branch
from
3e3001a
to
b673fcf
Compare
|
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#402 states that user might override the scc settings when he sets the ENV var
OPENJ9_JAVA_OPTIONS. Ideally the user should be aware that he was overriding the ENV set by base image and add on top that but for a better user experience this PR adds the-Xshareclassesoption toJAVA_TOOL_OPTIONSwhich is already being set.@dinogun @karianna Can i have your views on this ?
PS: This PR is currently work in progress as this might not turn as the perfect solution for the problem stated in #402 . Raising this PR to make incremental changes based on the discussion happening in this thread.
Signed-off-by: bharathappali [email protected]