Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illuminate what the pointOnCircle is doing in "How to create paths" #85

Open
ashryanbeats opened this issue Oct 9, 2018 · 2 comments
Open

Illuminate what the pointOnCircle is doing in "How to create paths" #85

ashryanbeats opened this issue Oct 9, 2018 · 2 comments
Assignees
@dkstevekwak
Labels
post-launch

Comments

@ashryanbeats
Copy link
Member

Submit an issue

Description of the issue

Currently says:

The angle is expressed in degrees. It must be converted to radians before passing it to the sine and cosine functions.

This is a bit abrupt.

  • Thus far in the flow, no angle has been discussed... so what angle?
  • Lead in with a mention about both arguments and where they'll come from.
  • Mention why we're returning coordinates as a string
@dkstevekwak
Copy link
Contributor

@ashryanbeats do bf43b3b and 8d282a2 address the issue?

@dkstevekwak dkstevekwak self-assigned this Nov 26, 2018
@dkstevekwak dkstevekwak mentioned this issue Nov 26, 2018
Open
@dkstevekwak
Copy link
Contributor

@ashryanbeats can you look at the comments above please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkstevekwak dkstevekwak

Labels
post-launch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashryanbeats @dkstevekwak