Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build does not embed bundle in content package #73

Open
jsedding opened this issue May 13, 2019 · 0 comments
Open

Build does not embed bundle in content package #73

jsedding opened this issue May 13, 2019 · 0 comments

Comments

@jsedding
Copy link

The {{content/pom.xml}} has an embed directive for the content-package plugin to embed the sample bundle. However, the bundle is not embedded, because there isn't a corresponding dependency definition. To further complicate matters, an old SNAPSHOT of the bundle is committed with the project sources at https://github.com/Adobe-Consulting-Services/acs-aem-samples/tree/master/content/src/main/content/jcr_root/apps/acs-samples/install.

This can be very confusing and is certainly nothing like the best-practices that a sample project should be demonstrating.

After fixing this locally, I still had to jump through some hoops to get the bundle to resolve on AEM 6.5. Maybe that's due to issues that have gone unnoticed in smoke tests due to this issue? Or maybe 6.5 is just not supported yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant