Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync takes a long time #7

Open
Adjective-Object opened this issue Mar 23, 2019 · 2 comments
Open

Sync takes a long time #7

Adjective-Object opened this issue Mar 23, 2019 · 2 comments

Comments

@Adjective-Object
Copy link
Owner

Adjective-Object commented Mar 23, 2019

It shouldn't take that long to traverse the document and generate markdown. I'm not sure if we're doing network transactions under the hood or what.

We are also re-traversing the whole document any time it is updated. Maybe instead we need to be listening to every block and keep those values as cached? I feel like that's a lot of complexity

@Speculative
Copy link

Notion has a built-in update feed, so I feel like diffed updates should be possible? I don't know if it's exposed in notion-py though.

@Adjective-Object
Copy link
Owner Author

It is, I would need to keep partial reconstructions of the tree stored in memory and then rebuild from a single node changing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants