Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Roles #216

Open
GalacticChimp opened this issue Nov 16, 2023 · 1 comment
Open

Refactor Roles #216

GalacticChimp opened this issue Nov 16, 2023 · 1 comment
Assignees
Labels
I: Major Coding significant rework or refactor
Milestone

Comments

@GalacticChimp
Copy link
Collaborator

GalacticChimp commented Nov 16, 2023

Description

Roles and their handling need to be refactored. Currently we have to reference them like role[100,18]. which is cumbersome and hard to read. The rework itself seems simple, but the issue is that there are abpi 1200 such references in the code, which will take a lot of time to resolve.

Proposed change

  • Rework role[100] into a human-readable enum or struct.
  • Replace all references to role[100].

Additional information

Some extra info: #195 (comment) from @OH296

@GalacticChimp GalacticChimp added the I: Major Coding significant rework or refactor label Nov 16, 2023
@GalacticChimp GalacticChimp added this to the 0.8.4.0 milestone Nov 16, 2023
@GalacticChimp GalacticChimp self-assigned this Nov 16, 2023
@OH296
Copy link
Collaborator

OH296 commented Nov 16, 2023

if you don't mind i'll probably have a go at this one as i think i know how to fixit fairly quickly without breaking anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: Major Coding significant rework or refactor
Projects
None yet
Development

No branches or pull requests

2 participants