fix: unit tests

AdaptiveConsulting · Nov 7, 2024 · 41ed9a4 · 41ed9a4
1 parent 50bef17
commit 41ed9a4
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 7 deletions.
diff --git a/packages/client/src/client/App/LiveRates/MainHeader/__tests__/MainHeader.test.tsx b/packages/client/src/client/App/LiveRates/MainHeader/__tests__/MainHeader.test.tsx
@@ -96,15 +96,15 @@ describe("MainHeader", () => {
     )
 
     act(() => {
-      fireEvent.click(screen.getByTestId("toggleButton"))
+      fireEvent.click(screen.getByTestId("action-toggleTileView"))
     })
 
     expect(screen.getByTestId("tile-EURUSD").textContent).toBe(
       "IsAnalytics: false",
     )
 
     act(() => {
-      fireEvent.click(screen.getByTestId("toggleButton"))
+      fireEvent.click(screen.getByTestId("action-toggleTileView"))
     })
 
     expect(screen.getByTestId("tile-EURUSD").textContent).toBe(

diff --git a/packages/client/src/client/App/Trades/GridRegion/GridRegion.tsx b/packages/client/src/client/App/Trades/GridRegion/GridRegion.tsx
@@ -61,6 +61,7 @@ export const GridRegion = <Row extends Trade>({
         <TradesStreamContext.Provider value={trades$}>
           <HighlightedRowContext.Provider value={highlightedRow}>
             <Region
+              aria-labelledby="trades-table-heading"
               fallback={<Loader ariaLabel="Loading trades blotter" />}
               Header={
                 <TradesHeader

diff --git a/packages/client/src/client/App/Trades/__tests__/FxTrades.core.test.tsx b/packages/client/src/client/App/Trades/__tests__/FxTrades.core.test.tsx
@@ -15,7 +15,7 @@ import { tradesMock } from "@/services/trades/__mocks__/_trades"
 import FxTrades from "../CoreFxTrades"
 import * as TableTrades from "../TradesState/tableTrades"
 
-vi.mock("../TradesGrid/utils")
+vi.mock("../GridRegion/utils")
 vi.mock("@openfin/core", () => ({
   fin: undefined,
 }))

diff --git a/packages/client/src/client/App/Trades/__tests__/FxTrades.filter.test.tsx b/packages/client/src/client/App/Trades/__tests__/FxTrades.filter.test.tsx
@@ -15,7 +15,7 @@ import { tradesMock } from "@/services/trades/__mocks__/_trades"
 import FxTrades from "../CoreFxTrades"
 import * as TableTrades from "../TradesState/tableTrades"
 
-vi.mock("../TradesGrid/utils")
+vi.mock("../GridRegion/utils")
 vi.mock("@openfin/core", () => ({
   fin: undefined,
 }))
@@ -30,7 +30,7 @@ vi.mock("../TradesState/tableTrades", async () => {
     useFxTradeRowHighlight: vi.fn().mockReturnValue(undefined),
   }
 })
-vi.mock("../TradesGrid/utils")
+vi.mock("../GridRegion/utils")
 vi.mock("react-virtualized-auto-sizer", () => ({
   default: ({
     children,

diff --git a/packages/client/src/client/App/Trades/__tests__/FxTrades.quickFilter.test.tsx b/packages/client/src/client/App/Trades/__tests__/FxTrades.quickFilter.test.tsx
@@ -22,7 +22,7 @@ vi.mock("../TradesState/tableTrades", async () => {
     useFxTradeRowHighlight: vi.fn().mockReturnValue(undefined),
   }
 })
-vi.mock("../TradesGrid/utils")
+vi.mock("../GridRegion/utils")
 vi.mock("react-virtualized-auto-sizer", () => ({
   default: ({
     children,

diff --git a/packages/client/src/client/components/TabBar/TabBar.tsx b/packages/client/src/client/components/TabBar/TabBar.tsx
@@ -46,7 +46,13 @@ export const TabBar = <T extends string>({
       <RightSection>
         {actions &&
           actions.toReversed().map(({ name, active, onClick, inner, size }) => (
-            <Action key={name} active={!!active} onClick={onClick} size={size}>
+            <Action
+              key={name}
+              active={!!active}
+              onClick={onClick}
+              size={size}
+              data-testid={`action-${name}`}
+            >
               {inner}
             </Action>
           ))}