Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI color change. #412

Open
ayushi0809 opened this issue Mar 25, 2023 · 1 comment
Open

UI color change. #412

ayushi0809 opened this issue Mar 25, 2023 · 1 comment

Comments

@ayushi0809
Copy link

image
We are not able to read text due the background color.
I have made few changes .
image
Should I do a PR for the same

@nevfy-y
Copy link

nevfy-y commented Dec 29, 2023

The color picker could be simplified by removing the row of colors not quite usable for a particular theme. Darker colors work bad on light theme, because the text is dark, and same for the dark theme - light text doesn't work on lighter colors. There is no need in giving options that work bad.

AW_colorpicker

There is another way of looking on those colors: lighter colors on the light theme are normal colors with lowered transparency. Same for the darker colors on dark theme.

When switching themes, lighter colors should be changed to their darker versions with the same hue. Normal colors (the middle row on the palette) should remain the same. Colors defined by the user should be recalculated, while palette colors could just be swapped with their darker/lighter sibling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants